Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse siwe authentication #547

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

manumonti
Copy link
Member

@manumonti manumonti commented Jul 11, 2024

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:
Add support to reuse SIWE messages on taco-web from other applications.

Issues fixed/closed:

  • Fixes #...

Related to https://github.com/nucypher/sprints/issues/22

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:
Based on #546 .

@derekpierre
Copy link
Member

Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸 - contributed to this, so my approval is implicit.

@derekpierre
Copy link
Member

Looking for reviews here.

@derekpierre derekpierre merged commit fc3ddf9 into nucypher:epic-auth Jul 23, 2024
4 checks passed
@manumonti manumonti deleted the reuse-siwe-authentication branch July 24, 2024 18:31
This was referenced Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants