Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple Porter URIs #553

Merged
merged 6 commits into from
Aug 9, 2024
Merged

Multiple Porter URIs #553

merged 6 commits into from
Aug 9, 2024

Conversation

vzotova
Copy link
Member

@vzotova vzotova commented Jul 18, 2024 •
edited
Loading

Type of PR:

  • Bugfix
  • Feature
  • Documentation
  • Other

Required reviews:

  • 1
  • 2
  • 3

What this does:

High-level idea of the changes introduced in this PR.
List relevant API changes (if any), as well as related PRs and issues.

Issues fixed/closed:
Refs #320

Why it's needed:

Explain how this PR fits in the greater context of the NuCypher Network.
E.g., if this PR address a nucypher/productdev issue, let reviewers know!

Notes for reviewers:
Based on #527

@vzotova vzotova self-assigned this Jul 18, 2024
@vzotova vzotova force-pushed the porter-chain branch 2 times, most recently from f4a868a to d5faf67 Compare July 24, 2024 20:59
@vzotova vzotova changed the title [WIP] Multiple Porter URIs Multiple Porter URIs Jul 24, 2024
@vzotova vzotova marked this pull request as ready for review July 24, 2024 22:14
piotr-roslaniec
piotr-roslaniec approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@piotr-roslaniec piotr-roslaniec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very fine

Welcome on board

@vzotova vzotova mentioned this pull request Jul 25, 2024
Merged
7 tasks
manumonti
manumonti approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@manumonti manumonti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here! 👏

I have some small suggestions, any of them is a blocker.

packages/shared/test/porter.test.ts Outdated Show resolved Hide resolved
packages/shared/test/porter.test.ts Outdated Show resolved Hide resolved
demos/taco-demo/src/App.tsx Show resolved Hide resolved
@derekpierre
Copy link
Member

@vzotova Can we hold off on merging this into epic-auth until after the sprint retrospective call today?

@vzotova
Copy link
Member Author

vzotova commented Jul 26, 2024

@vzotova Can we hold off on merging this into epic-auth until after the sprint retrospective call today?

Of course

@derekpierre
Copy link
Member

@vzotova Can we hold off on merging this into epic-auth until after the sprint retrospective call today?

Of course

Let's put this PR into a separate EPIC branch.

@vzotova vzotova changed the base branch from epic-auth to epic-uris July 26, 2024 16:33
KPrasch
KPrasch reviewed Jul 30, 2024
View reviewed changes
packages/shared/src/porter.ts
Comment on lines 20 to 22
mainnet: 'https://porter.nucypher.community',
tapir: 'https://porter-tapir.nucypher.community',
oryx: 'https://porter-oryx.nucypher.community',
lynx: 'https://porter-lynx.nucypher.community',
Copy link
Member

@KPrasch KPrasch Jul 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're trying to deprecate the .community domain in favor of the .io domain. I know it's a little but out of scope but it's a quick and easy change to include here. #549

Suggested change
mainnet: 'https://porter.nucypher.community',
tapir: 'https://porter-tapir.nucypher.community',
oryx: 'https://porter-oryx.nucypher.community',
lynx: 'https://porter-lynx.nucypher.community',
mainnet: 'https://porter.nucypher.io',
tapir: 'https://porter-tapir.nucypher.io',
lynx: 'https://porter-lynx.nucypher.io',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed in #555

KPrasch
KPrasch reviewed Jul 30, 2024
View reviewed changes
Copy link
Member

@KPrasch KPrasch left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR intend to integrate with the porter URIs from the nucypher/nucypher-porter repo?

Ah, nevermind. I see you have already opened #555.

https://raw.githubusercontent.com/nucypher/nucypher-porter/development/porter_instances.json

@vzotova vzotova changed the base branch from epic-uris to main July 30, 2024 13:35
@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for taco-demo ready!

Name Link
🔨 Latest commit 1977815
🔍 Latest deploy log https://app.netlify.com/sites/taco-demo/deploys/66a8ee45891ff300074d5bb2
😎 Deploy Preview https://deploy-preview-553--taco-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Jul 30, 2024 •
edited
Loading

✅ Deploy Preview for taco-nft-demo ready!

Name Link
🔨 Latest commit 1977815
🔍 Latest deploy log https://app.netlify.com/sites/taco-nft-demo/deploys/66a8ee46efe09d00087a583e
😎 Deploy Preview https://deploy-preview-553--taco-nft-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

derekpierre
derekpierre reviewed Aug 9, 2024
View reviewed changes
packages/shared/src/porter.ts Show resolved Hide resolved
packages/taco/src/tdec.ts
@@ -61,7 +61,7 @@ export const encryptMessage = async (
export const retrieveAndDecrypt = async (
provider: ethers.providers.Provider,
domain: Domain,
porterUri: string,
porterUris: string[],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe the functions in this module are exposed externally as part of the taco-web library. Would it be simpler to create the PorterClient object in the taco.ts module and pass that object in instead of the string array, or does that cause other issues?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd need help with that, I'm not that familiar with taco-web to answer your questions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be addressed vi #560 - #560 (comment).

@derekpierre derekpierre mentioned this pull request Aug 9, 2024
Merged
7 tasks
derekpierre
derekpierre approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@derekpierre derekpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@derekpierre derekpierre merged commit 142a509 into nucypher:main Aug 9, 2024
8 of 9 checks passed
@derekpierre derekpierre mentioned this pull request Aug 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-roslaniec piotr-roslaniec piotr-roslaniec approved these changes

@manumonti manumonti manumonti approved these changes

@derekpierre derekpierre derekpierre approved these changes

@theref theref theref approved these changes

@KPrasch KPrasch KPrasch approved these changes

@cygnusv cygnusv Awaiting requested review from cygnusv

Assignees

@vzotova vzotova

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vzotova @derekpierre @KPrasch @theref @manumonti @piotr-roslaniec