New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing pubDate while sorting #191

Closed

fritx wants to merge 2 commits into nuejs:master from fritx:pubdate-title-sort

Collaborator

fritx commented Feb 5, 2024 •

edited

Loading

Commits based on PR #190

Sort by title when pubDate is missing (pubDate defaults to -1 , comparing with existing dates). Thoughts?
Complete the test-cases for no front provided

fritx added 2 commits

February 5, 2024 21:12


          Fix failed test with createFront, fix nuejs#185

461cd5a


          Sort with title when pubDate is not provided (default to -1)

39415fc

fritx changed the title ~~Pubdate title sort~~ Handle missing pubDate while sorting

nobkd mentioned this pull request

Fix failed test with createFront, fix #185 #190

Merged

fritx marked this pull request as draft

February 7, 2024 12:44

Collaborator Author

fritx commented Feb 7, 2024

Converted to DRAFT because I get to realize that sorting by title is not good, the original order should be kept instead.

fritx closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet