Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Again! Fix the failed CI #214

Merged
merged 4 commits into from
Feb 22, 2024
Merged

Again! Fix the failed CI #214

merged 4 commits into from
Feb 22, 2024

Conversation

fritx
Copy link
Collaborator

@fritx fritx commented Feb 22, 2024

✅ CI is now passing again:
https://github.com/fritx/nue/actions/runs/8000550563
https://github.com/fritx/nue/actions/runs/8000785880

  1. Attempt to pass the CI by handling missing pubDate while sorting
  2. Attempt to pass the Windows CI by adapting dir path
  3. Attempt to pass the (Node) CI by replacing import.meta.resolve
    • Tried import.meta.resolve iwth both Node@18.18 and Node@18.19.1 in CI but failed.
    • While running *.mjs with import.meta.resolve is fine with Node@18.19.1 locally. Any one knows why?
  4. Attempt to pass the Windows CI by removing the leading slash from absolute path
  • The logic appears in several places and can be extracted in the future, maybe next PR.

@fritx fritx requested a review from tipiirai February 22, 2024 06:50
@fritx
Copy link
Collaborator Author

fritx commented Feb 22, 2024

Oops. I guess CI failed here because of the latest GLOW-related commits.
You guys are commiting so fast 🚀 @tipiirai

@tipiirai
Copy link
Contributor

Outch. I'll fix that

@tipiirai
Copy link
Contributor

I just pushed a fix to glow test suite, but it's not passing here. I have updated the version number to 0.1.2. Is that the reason?

@fritx
Copy link
Collaborator Author

fritx commented Feb 22, 2024

Outch. I'll fix that

I also had a fix on that in the context of another PR. - #215 (Looks equivalent!)
I'll try to rebase the latest master. Wait.

not passing here. I have updated the version number to 0.1.2. Is that the reason?

I'm not sure but it is prossible as we had the same confusion some time ago (CI not passing right after version bumping).

@fritx
Copy link
Collaborator Author

fritx commented Feb 22, 2024

Now the PR is ready @tipiirai

@tipiirai tipiirai merged commit 493aa13 into nuejs:master Feb 22, 2024
3 checks passed
@tipiirai
Copy link
Contributor

Perfect. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants