docs: fix docs #292
docs: fix docs #292
Conversation
| background-color: #0005; | ||
| backdrop-filter: blur(4px); | ||
| transition: .5s; | ||
| } | ||
|
|
||
| /* styles when the popover is about to be displayed */ | ||
| @starting-style { |
There was a problem hiding this comment.
Changed, because order matters.
Note
The @starting-style at-rule and the "original rule" have the same specificity. To ensure that starting styles get applied, include the @starting-style at-rule after the "original rule". If you specify the @starting-style at-rule before the "original rule", the original styles will override the starting styles.
From: https://developer.mozilla.org/en-US/docs/Web/CSS/@starting-style
| @@ -93,7 +92,7 @@ The two metrics that measure page rendering speed are [first contentful paint](/ | |||
|
|
|||
|
|
|||
|
|
|||
| Please compare [Tailwind metrics](//pagespeed.web.dev/analysis/https-spotlight-tailwindui-com/cqtnf4xxoy?form_factor=mobile) with [Semantic CSS metcis ](//pagespeed.web.dev/analysis/https-nuejs-org-spotlight/6nnhwwnz8b?form_factor=mobile). | |||
| Please compare [Tailwind metrics](//pagespeed.web.dev/analysis/https-spotlight-tailwindui-com/cqtnf4xxoy?form_factor=mobile) with [Semantic CSS metrics](//pagespeed.web.dev/analysis/https-nuejs-org-spotlight/6nnhwwnz8b?form_factor=mobile). | |||
There was a problem hiding this comment.
These links do not work anymore, and the page-speeds are negligibly different:
Nue: https://pagespeed.web.dev/analysis/https-nuejs-org-spotlight/i0itoo400b?form_factor=mobile
Tailwind: https://pagespeed.web.dev/analysis/https-spotlight-tailwindui-com/98p017y0jm?form_factor=mobile
Previous comment: 89aaa51#r144877042
The previous links were broken, probably, because the links are thrown away after some time.
The results can probably be saved with e.g. a local lighthouse installation (via bun / npm), and then the result file can get served.
AFAIK this generates a single html file, so it shouldn't be to hard.
packages/nuejs.org/docs/tags.md
Outdated
| @@ -219,9 +219,9 @@ Options given as YAML: | |||
|
|
|||
| `poster` a URL for an image to be shown before the playback starts | |||
|
|
|||
| `preload` a [hint to the browser][preload] on what to load prior playback | |||
| `preload` <span>a [hint to the browser][preload] on what to load prior playback</span> | |||
There was a problem hiding this comment.
Would break because of flex on .options otherwise, as a new element is inserted, and flex breaks the text wrapping (most noticeable on small screens) and removes spaces.
Currently, for whatever reason, strips the underline from the link when wrapped in a span... 🤷
Previous comments:
There was a problem hiding this comment.
Without span:
- breaks the text flow
With span:
- missing underline on link
nobkd
force-pushed
the
fix-docs
branch
2 times, most recently
from
978506b
to
8d0c76b
Compare
nobkd
force-pushed
the
fix-docs
branch
6 times, most recently
from
a91164b
to
7fb840e
Compare
nobkd
force-pushed
the
fix-docs
branch
6 times, most recently
from
3fd2e7a
to
fac195b
Compare
Co-authored-by: seneca <seneca@users.noreply.github.com>
|
This was HUGE! Thank you! |
These are mostly typo / grammar / link fixes, as well as markdown formatting.
I also added some TODOs for links, which are not contained in the docs (e.g. todomvc example)
I think this can be merged after
are done, as they are each smaller in scope, also because they're only one file each.
Some of my changes will probably already be fixed then, so I will always rebase, when any of them are merged.