Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate packages.config restore implementations by minimizing discrepancies #13233

Closed
nkolev92 opened this issue Feb 9, 2024 · 1 comment · Fixed by NuGet/NuGet.Client#5628
Assignees
Milestone

Comments

@nkolev92
Copy link
Member

nkolev92 commented Feb 9, 2024

Unfortunately we have 3 different implementations of packages.config restore.
A lot of that is due to the difference in reading the packages and part of it is not wanting to make public APIs for PC restore.

Those 3 implementations are:

nuget.exe restore
msbuild.exe /t:restore
VS restore
There's a bunch of differences in how the PackageRestoreManager gets called. It's made my work for PC restore vulnerability checking challenging, because the calls are not unified.

@nkolev92 nkolev92 self-assigned this Feb 9, 2024
@ghost
Copy link

ghost commented Feb 9, 2024

@nkolev92 Issue is missing Type label, remember to add a Type label

@ghost ghost added the missing-required-type The required type label is missing. label Feb 9, 2024
@nkolev92 nkolev92 added Priority:2 Issues for the current backlog. Type:Bug Functionality:Restore Style:Packages.Config and removed missing-required-type The required type label is missing. labels Feb 9, 2024
@kartheekp-ms kartheekp-ms added this to the 6.10 milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants