Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate in the Assets file when Package Source Mapping was enabled #13525

Open
donnie-msft opened this issue Jun 7, 2024 · 1 comment
Open
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug

Comments

@donnie-msft
Copy link
Contributor

NuGet Product(s) Affected

NuGet.exe, Visual Studio Package Management UI, Visual Studio Package Manager Console, MSBuild.exe, dotnet.exe, NuGet SDK

Current Behavior

The assets file does not log any indication of whether Package Source Mapping was used during the restore. When investigating a customer's binlog, for example, the only way to know this status is to ask the customer.

Desired Behavior

Similar to how other features are recorded in the assets file, eg,

"centralPackageVersionsManagementEnabled": true,
"CentralPackageTransitivePinningEnabled": true,

Add something like this to the assets file:
"PackageSourceMappingEnabled": true,

Additional Context

No response

@donnie-msft donnie-msft added Priority:2 Issues for the current backlog. Type:DCR Design Change Request Functionality:Restore Area:PackageSourceMapping Issues related to the package source mapping feature labels Jun 7, 2024
@nkolev92 nkolev92 added Type:Bug and removed Type:DCR Design Change Request labels Jun 17, 2024
@nkolev92
Copy link
Member

Since it's internal tweaking the label to bug since DCR will get flagged in the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:PackageSourceMapping Issues related to the package source mapping feature Functionality:Restore Priority:2 Issues for the current backlog. Type:Bug
Projects
None yet
Development

No branches or pull requests

2 participants