Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dotnet nuget why on non-SDK style projects #13576

Closed
zivkan opened this issue Jun 25, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5922
Closed

Enable dotnet nuget why on non-SDK style projects #13576

zivkan opened this issue Jun 25, 2024 · 0 comments · Fixed by NuGet/NuGet.Client#5922
Assignees
Labels
Area:NuGetAudit Functionality:Why dotnet nuget why Priority:2 Issues for the current backlog. Type:Feature
Milestone

Comments

@zivkan
Copy link
Member

zivkan commented Jun 25, 2024

NuGet Product(s) Involved

dotnet.exe

The Elevator Pitch

dotnet nuget why currently requires you to point to a project file, but the .NET SDK can only evaluate SDK style projects. Many non-SDK style Visual Studio projects try to import MSBuild props/targets files that don't exist in the .NET SDK and therefore trying to read project properties (to find the assets file) fails.

dotnet nuget why is particularly useful for investigating why a package with a known vulnerability is used by a project, so allowing the command to work for non-SDK style projects will help customers investigate known vulnerabilities.

dotnet nuget why should either allow a project.assets.json file to be passed as an argument instead of a project file.

We can instruct customers that they can find the assets file location using msbuild.exe path\to\project.csproj -getProperty:ProjectAssetsFile

Additional Context and Details

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:NuGetAudit Functionality:Why dotnet nuget why Priority:2 Issues for the current backlog. Type:Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant