Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use long? (or string) for JobId in Tools.CoverallsNet #1116

Closed
IT-VBFK opened this issue Jan 17, 2023 · 1 comment · Fixed by #1131
Closed

Use long? (or string) for JobId in Tools.CoverallsNet #1116

IT-VBFK opened this issue Jan 17, 2023 · 1 comment · Fixed by #1131
Assignees
@ITaluone
Labels
bug
Milestone
v7.0.1

Comments

@IT-VBFK
Copy link

IT-VBFK commented Jan 17, 2023 •
edited
Loading

Description

When passing the GitHubActions.RunId as JobId.. that does not work anymore.. since the run id is beyond int.MaxValue.

image

Usage Example

No response

Alternative

No response

Could you help with a pull-request?

Maybe.. How does the CoverallsNet.Generated.cs generates? Do I only need to change int to long and rebuild?
@IT-VBFK IT-VBFK changed the title Use long? for JobId in Tools.CoverallsNet Use long? (or string) for JobId in Tools.CoverallsNet Jan 17, 2023
@ITaluone
Copy link
Contributor

The main problem here is the overflow that happens.

To avoid this string would be enough.. because on CLI it is just string

@ITaluone ITaluone mentioned this issue Feb 13, 2023
Merged
3 tasks
@matkoch matkoch removed the triage label May 7, 2023
@matkoch matkoch modified the milestones: v7.1.0, v7.0.1 May 7, 2023
@matkoch matkoch added bug and removed enhancement labels May 11, 2023
@matkoch matkoch closed this as completed May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ITaluone ITaluone

Labels
bug
Projects
None yet
Milestone
v7.0.1
Development

Successfully merging a pull request may close this issue.

Change type of JobId from int to string at coveralls.net tool ITaluone/nuke
3 participants
@matkoch @ITaluone @IT-VBFK