Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yajl and Gson libraries should be required in lowercase #6

Closed
nukeproof opened this issue Jul 6, 2015 · 0 comments
Closed

Yajl and Gson libraries should be required in lowercase #6

nukeproof opened this issue Jul 6, 2015 · 0 comments
Assignees

Comments

@nukeproof
Copy link
Owner

In OandaAPI::Streaming::JsonParser#try_adapter, line 94 attempts to load an adapter library.

require REQUIREMENT_MAP.fetch sym

The values in REQUIREMENT_MAP should be defined in lowercase to correctly require the libraries in line 94. Without this change, the libraries fail to be required under *nix.
change:

      REQUIREMENT_MAP = {
        gson: "Gson",
        yajl: "Yajl"
      }

to:

      REQUIREMENT_MAP = {
        gson: "gson",
        yajl: "yajl"
      }
nukeproof added a commit that referenced this issue Jul 7, 2015
Fixes issue #6 - Yajl and Gson libraries should be required in lowercase
@nukeproof nukeproof self-assigned this Jul 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant