Bugfix json-marshal collaborators in Ticket #206
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for the library!
Here's a PR to fix a small bug when json-marshalling a
Ticket
.This happens, e.g. when creating a Ticket in ticket.go:242
which marshals the passed Ticket in zendesk.go:117
The json sent to the server is then something like this:
Although it should be
"collaborators" : []
because it's clearly a list.The reason is, that
json.Marshal(...)
is called on a value ofTicket
instead of a pointer, i.e. the functionfunc (c * Collaborators) MarshalJSON() ([]byte, error)
is never called.In production there is no problem because Zendesk tolerates the data.
In our application however we mock Zendesk's http interface for unit testing. In the mock we'd like to
json.Unmarshal
the received data into aTicket
to send it back to the caller. This fails withjson: cannot unmarshal object into Go struct field Ticket.ticket.collaborators of type []interface {}
.I'd like to fix that.