is there any plan to make use of async and Future ?

[arussel]

No description provided.

[tsuyoshizawa]

You talk about Playframework module?
Yes, there is. We will support returning Future[SimpleResult] by issueAccessToken and authorize both methods.

Expect code:

import scalaoauth2.provider._
object MyController extends Controller with OAuth2Provider {
  def list = Action.async { implicit request =>
    asyncAuthorize(new MyDataHandler()) { authInfo =>
      val user = authInfo.user // User is defined on your system
      // access resource for the user
    }
  }
}

[arussel]

exactly what I meant 👍
I would be happy to test it as soon as it is pushed

[arussel]

with the DataHandler having method like:
def createAccessToken(authInfo: AuthInfo[U]): Future[AccessToken]

[tsuyoshizawa]

I added OAuth2AsyncProvider.

We can use Future from OAuth2Provider to OAuth2AsyncProvider.

[arussel]

thanks

[arussel]

Thanks for implementing this feature, any plan to have the DataHandler returns Future too ? my db call to fetch token, authinfo and users are using Future.

[tsuyoshizawa]

I don't have a plan yet that DataHandler supports Future.

[bwlim]

https://github.com/finagle/finagle-oauth2
=> this project seems to implement async version of DataHandler

Why don't you make DataHandler async...?
Somebody like me wants system to be fully async(Reactive System, http://www.reactivemanifesto.org/)
Is there any reason for not implementing async DataHandler?

[tsuyoshizawa]

Please give us your feedback to #18