Make client credentials optional password #33 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctoomey
pushed a commit
to ctoomey/scala-oauth2-provider
that referenced
this pull request
Oct 6, 2014
|
I sent you a PR my feedback. How is this? Many thanks for your PR. |
ctoomey
force-pushed
the
client-cred-optional-for-password
branch
from
ef5bfc4
to
29dc8c8
Compare
|
I've included your change and squashed my commits, hope it's good to go. Please let me know after you've had a chance to update the maven repo. Thanks for taking this change. |
tsuyoshizawa
added a commit
that referenced
this pull request
Oct 8, 2014
Make client credentials optional password #33
|
@ctoomey I have merged your PR and published version 0.10.0-SNAPSHOT. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for #33 .