added a test comparing the javascript release and the java port #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SM4 Thank you for PR. I will fix it soon. Please wait a few. |
|
Thanks. I see a null pointer exception when running the JavaPortTest from Travic CI. It's the loading of the resource (the javascript file). I am not seeing the same problem locally. Any ideas? Also do you want to make this test part of your testing? It's passing locally now with the changes you have made. |
vvatanabe
reviewed
Dec 7, 2016
| @BeforeClass | ||
| public static void initEngine() { | ||
| ScriptEngineManager manager = new ScriptEngineManager(); | ||
| engine = manager.getEngineByName("nashorn"); |
There was a problem hiding this comment.
@SM4
The Java environment set in .travis.yml is java 1.7. Using Nashorn requires java 1.8. Try passing string arg "js" to ScriptEngineManager#getEngineByName.
engine = manager.getEngineByName("js");
|
I've added a compatibility fix for Rhino (I believe that's the JS engine in JDK 7). |
|
@SM4 Awesome! Thank you for a wonderful fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are looking for a port of the Zxcvbn library. Yours looks good, but I've created a test that compares the strength of the passwords in the MeasureTest calculated from your Java version with the calculated strength from the the original Javascript and found some differences. It also relates to your issue #8
The test is currently failing for three passwords and the long password has been commented out (the one failing in the original v4.4.1).