Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape colons in Ark requests #4114

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Escape colons in Ark requests #4114

merged 2 commits into from
Aug 21, 2024

Conversation

mbklein
Copy link
Contributor

@mbklein mbklein commented Aug 20, 2024

Summary

Escape colons in Ark requests

Specific Changes in this PR

  • Update ANVL escaping to include all escapable characters (%:\r\n)
  • Fix a bunch of longstanding compiler warnings

Version bump required by the PR

See Semantic Versioning 2.0.0 for help discerning which is required.

  • Patch
  • Minor
  • Major

Steps to Test

  1. Update your dev.local.exs to point to the live cdlib test ARK API:
    a. copy the config :meadow, ark: %{...} stanza out of config.exs into dev.local.exs
    b. replace url: aws_secret(...) with url: "https://ezid.cdlib.org/"
  2. Create a work (or edit an existing one) with a colon in the title
  3. Mint an ark for that work

🚀 Deployment Notes

Note - if you check any of these boxes go to the (always open) main <- staging PR and add detailed notes and instructions to help out others who may end up deploying your changes to production

  • Backward compatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Backwards-incompatible API changes
    • Database Schema changes
    • GraphQL API
    • Elasticsearch API
    • Ingest Sheet
    • CSV metadata export/update API
    • Shared Links export API
  • Requires data migration
  • Requires database triggers disabled during deployment/migration
  • Requires reindex
  • Terraform changes
    • Adds/requires new or changed Terraform variables
  • Pipeline configuration changes (requires mix meadow.pipeline.setup run)
  • Requires new variable added to miscellany
  • Specific deployment synchronization instructions with other apps/API's
  • Other specific instructions/tasks

Tested/Verified

  • End users/stakeholders

@mbklein mbklein requested review from bmquinn and kdid August 20, 2024 22:27
@mbklein mbklein merged commit e4fa42d into deploy/staging Aug 21, 2024
4 checks passed
@mbklein mbklein deleted the 5132-escape-anvl branch August 21, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants