Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use more idiomatic Rust patterns #14

Merged
merged 7 commits into from
Jul 6, 2023
Merged

Refactor to use more idiomatic Rust patterns #14

merged 7 commits into from
Jul 6, 2023

Commits on Jul 5, 2023

  1. Remove redundant closure

    @Yossipossi1
    Yossipossi1 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    bf3e969 View commit details
    Browse the repository at this point in the history

  2. Remove one-branch wildcard matches 

    Helps reduce cognitive overhead when developing.
    @Yossipossi1
    Yossipossi1 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    c1ea0fa View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary "where" 

    Trait bound can be stated more concisely
    @Yossipossi1
    Yossipossi1 committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    8842ca1 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Replace series of if conditions with match 

    This is not only more concise, but is also very slightly faster.
    @Yossipossi1
    Yossipossi1 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ca4b00f View commit details
    Browse the repository at this point in the history

  2. Refactor control flow to be more idiomatic 

    This is mostly fixing some default-allow cargo clippy lints.
    @Yossipossi1
    Yossipossi1 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    0397f09 View commit details
    Browse the repository at this point in the history

  3. Change unwrap_or to unwrap_or_else 

    https://rust-lang.github.io/rust-clippy/master/index.html#/or_fun_call
    @Yossipossi1
    Yossipossi1 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    4df567f View commit details
    Browse the repository at this point in the history

  4. Add underscores to improve number readability

    @Yossipossi1
    Yossipossi1 committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    2172751 View commit details
    Browse the repository at this point in the history