Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add support for PHP 8; Change phpunit to 9.5 #24

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Feature: Add support for PHP 8; Change phpunit to 9.5 #24

merged 1 commit into from
Jun 17, 2021

Conversation

jchodzicki
Copy link
Contributor

No description provided.

@dducro
Copy link

dducro commented Jun 15, 2021

Please merge this PR

This was referenced Jun 15, 2021
Closed
Closed
@jchodzicki
Copy link
Contributor Author

jchodzicki commented Jun 17, 2021 via email

@nullpunkt
Copy link
Owner

Hey! Thank you for the upgrade. Did you check if your fix also works with PHP Versions <=7 ? There should be at least support for PHP 6 and 7.

@dducro
Copy link

dducro commented Jun 17, 2021 •
edited
Loading

I confirm this version works om 7.3 and 7.4

@jchodzicki
Copy link
Contributor Author

Hey! Thank you for the upgrade. Did you check if your fix also works with PHP Versions <=7 ? There should be at least support for PHP 6 and 7.

https://www.php.net/supported-versions.php
This will be working on supported versions.

@nullpunkt nullpunkt merged commit bf4ae48 into nullpunkt:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jchodzicki @dducro @nullpunkt