Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expect Yt::HTTPError instead of Yt::NoItemsError to pass test #15

Closed
wants to merge 1 commit into from

Conversation

kangkyu
Copy link
Contributor

@kangkyu kangkyu commented Dec 5, 2018

we need this change because YouTube used to return empty array for the same request -- something like this (example of video)

{
 "kind": "youtube#videoListResponse",
 "etag": "\"XI7nbFXulYBIpL0ayR_gDh3eu1k/Rk41fm-2TD0VG1yv0-bkUvcBi9s\"",
 "pageInfo": {
  "totalResults": 0,
  "resultsPerPage": 0
 },
 "items": []
}

but now they respond with 500 'Backend Error'.

{
 "error": {
  "errors": [
   {
    "domain": "global",
    "reason": "backendError",
    "message": "Backend Error"
   }
  ],
  "code": 500,
  "message": "Backend Error"
 }
}

YouTube used to return empty array for the same request but now
they respond with 500 'Backend Error'.
@kangkyu kangkyu requested a review from dgb December 5, 2018 17:46
@dgb
Copy link

dgb commented Dec 5, 2018

Is that a consistent behavior? That seems like a bug in YouTube's API. Is there something weird with the test setup/request?

@kangkyu
Copy link
Contributor Author

kangkyu commented Dec 5, 2018

Yes it can be a bug. I should look it up if there's any bug report on it or make a bug report first.

@kangkyu kangkyu closed this Dec 5, 2018
@kangkyu kangkyu deleted the fix-test branch December 6, 2018 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants