Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data race in pbqmanager #348

Closed
vigith opened this issue Nov 14, 2022 · 0 comments · Fixed by #349
Closed

data race in pbqmanager #348

vigith opened this issue Nov 14, 2022 · 0 comments · Fixed by #349
Assignees
Labels
area/reduce Reduce operations like GroupByKey bug Something isn't working
Milestone

Comments

@vigith
Copy link
Member

vigith commented Nov 14, 2022

==================
WARNING: DATA RACE
Read at 0x00c0000e25d0 by goroutine 32:
  runtime.mapiterinit()
      /opt/hostedtoolcache/go/1.19.2/x64/src/runtime/map.go:815 +0x0
  github.com/numaproj/numaflow/pkg/pbq.(*Manager).ShutDown()
      /home/runner/work/numaflow/numaflow/pkg/pbq/pbqmanager.go:216 +0x126
  github.com/numaproj/numaflow/pkg/reduce/readloop.(*ReadLoop).ShutDown()
      /home/runner/work/numaflow/numaflow/pkg/reduce/readloop/readloop.go:227 +0x1bd
  github.com/numaproj/numaflow/pkg/reduce.(*DataForward).Start()
      /home/runner/work/numaflow/numaflow/pkg/reduce/reduce.go:91 +0x16e
  github.com/numaproj/numaflow/pkg/reduce.TestDataForward_StartWithNoOpWM.func7()
      /home/runner/work/numaflow/numaflow/pkg/reduce/reduce_test.go:209 +0x58

Previous write at 0x00c0000e25d0 by goroutine 29:
  runtime.mapdelete_faststr()
      /opt/hostedtoolcache/go/1.19.2/x64/src/runtime/map_faststr.go:301 +0x0
  github.com/numaproj/numaflow/pkg/pbq.(*Manager).deregister()
      /home/runner/work/numaflow/numaflow/pkg/pbq/pbqmanager.go:256 +0x1b2
  github.com/numaproj/numaflow/pkg/pbq.(*PBQ).GC()
      /home/runner/work/numaflow/numaflow/pkg/pbq/pbq.go:91 +0x144
  github.com/numaproj/numaflow/pkg/reduce/pnf.(*ProcessAndForward).Forward()
      /home/runner/work/numaflow/numaflow/pkg/reduce/pnf/processandforward.go:136 +0x5f3
  github.com/numaproj/numaflow/pkg/reduce/readloop.(*orderedForwarder).forward()
      /home/runner/work/numaflow/numaflow/pkg/reduce/readloop/ordered.go:165 +0xdb9
  github.com/numaproj/numaflow/pkg/reduce/readloop.(*orderedForwarder).startUp.func1()
      /home/runner/work/numaflow/numaflow/pkg/reduce/readloop/ordered.go:67 +0x58

Goroutine 32 (running) created at:
  github.com/numaproj/numaflow/pkg/reduce.TestDataForward_StartWithNoOpWM()
      /home/runner/work/numaflow/numaflow/pkg/reduce/reduce_test.go:209 +0xaa9
  testing.tRunner()
      /opt/hostedtoolcache/go/1.19.2/x64/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.19.2/x64/src/testing/testing.go:1493 +0x47

Goroutine 29 (running) created at:
  github.com/numaproj/numaflow/pkg/reduce/readloop.(*orderedForwarder).startUp()
      /home/runner/work/numaflow/numaflow/pkg/reduce/readloop/ordered.go:67 +0xdc
  github.com/numaproj/numaflow/pkg/reduce/readloop.NewReadLoop()
      /home/runner/work/numaflow/numaflow/pkg/reduce/readloop/readloop.go:84 +0x2de
  github.com/numaproj/numaflow/pkg/reduce.NewDataForward()
      /home/runner/work/numaflow/numaflow/pkg/reduce/reduce.go:70 +0x259
  github.com/numaproj/numaflow/pkg/reduce.TestDataForward_StartWithNoOpWM()
      /home/runner/work/numaflow/numaflow/pkg/reduce/reduce_test.go:206 +0x9ac
  testing.tRunner()
      /opt/hostedtoolcache/go/1.19.2/x64/src/testing/testing.go:1446 +0x216
  testing.(*T).Run.func1()
      /opt/hostedtoolcache/go/1.19.2/x64/src/testing/testing.go:1493 +0x47
==================
@vigith vigith added bug Something isn't working area/reduce Reduce operations like GroupByKey labels Nov 14, 2022
vigith added a commit that referenced this issue Nov 14, 2022
Signed-off-by: Vigith Maurice <vigith@gmail.com>
ashwinidulams pushed a commit that referenced this issue Nov 14, 2022
Signed-off-by: Vigith Maurice <vigith@gmail.com>
@vigith vigith assigned vigith and unassigned yhl25 Nov 14, 2022
@vigith vigith added this to the v0.7 milestone Nov 15, 2022
whynowy pushed a commit that referenced this issue Nov 18, 2022
Signed-off-by: Vigith Maurice <vigith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/reduce Reduce operations like GroupByKey bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants