feat: update tcp client connections #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
whynowy
reviewed
Dec 21, 2023
| func BuildConnAddrs(numCpu int) []string { | ||
| // buildConnAddrs Populate the connection list for the clients | ||
| // Format (serverAddr, serverIdx) : (0.0.0.0:5551, 1), (0.0.0.0:5552, 2) | ||
| func buildConnAddrs(numCpu int, servPorts []string) []string { |
There was a problem hiding this comment.
numCpu could be potentially not equal to len(servPorts), so the logic below is risky.
There was a problem hiding this comment.
From the SDK side they will both be the same value as numCpu is written to the server info as the number of server instances required in multiproc.
But I can actually do away with the variable itself and just use servPorts and len(servPorts), I guess would be easier for understanding
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
whynowy
approved these changes
Dec 21, 2023
vigith
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the grpc client to use multiple sockets for TCP connections instead of a single port with reuse