Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add idle handler offset nil check #1489

Merged
merged 3 commits into from
Feb 3, 2024

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Feb 2, 2024

Add idle handler offset nil check to fix the panic.

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x1d493cc]
goroutine 369 [running]:
github.com/numaproj/numaflow/pkg/watermark/publish.(*publish).PublishIdleWatermark(0xc000598120, {0xc00064c640?, 0x41?, 0x3bb0be0?}, {0x0, 0x0}, 0x1)
	/home/runner/work/numaflow/numaflow/pkg/watermark/publish/publisher.go:207 +0x16c
github.com/numaproj/numaflow/pkg/shared/idlehandler.PublishIdleWatermark({0x294e5e8, 0xc0007dc300}, {0x294ed20, 0xc000222310}, {0x294eee0, 0xc000598120}, {0x294ef18, 0xc00065eb60}, 0xc00061e0a0?, {0x258897f, ...}, ...)
	/home/runner/work/numaflow/numaflow/pkg/shared/idlehandler/idlehandler.go:62 +0x645
github.com/numaproj/numaflow/pkg/udf/forward.(*InterStepDataForward).forwardAChunk(0xc00001a8c0, {0x294e5e8?, 0xc0007dc300})
	/home/runner/work/numaflow/numaflow/pkg/udf/forward/forward.go:381 +0x1ec7
github.com/numaproj/numaflow/pkg/udf/forward.(*InterStepDataForward).Start.func1()
	/home/runner/work/numaflow/numaflow/pkg/udf/forward/forward.go:156 +0xf6
created by github.com/numaproj/numaflow/pkg/udf/forward.(*InterStepDataForward).Start
	/home/runner/work/numaflow/numaflow/pkg/udf/forward/forward.go:135 +0xca

Also update the goroutine in map_udf.go Start function

jyu6 and others added 2 commits February 1, 2024 16:41
@jy4096 jy4096 marked this pull request as ready for review February 2, 2024 18:23
@jy4096 jy4096 requested a review from yhl25 February 2, 2024 18:24
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
@jy4096 jy4096 marked this pull request as draft February 2, 2024 18:32
@jy4096 jy4096 marked this pull request as ready for review February 2, 2024 18:55
@jy4096 jy4096 merged commit 345e7ca into numaproj:main Feb 3, 2024
20 checks passed
@jy4096 jy4096 deleted the idle-handler-nil-check branch February 3, 2024 04:41
whynowy pushed a commit that referenced this pull request Feb 11, 2024
Signed-off-by: jyu6 <juanlu_yu@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants