chore: Exposing pipeline processing lag metrics #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1839 +/- ##
==========================================
- Coverage 54.35% 54.24% -0.12%
==========================================
Files 284 285 +1
Lines 28020 28058 +38
==========================================
- Hits 15231 15219 -12
- Misses 11874 11930 +56
+ Partials 915 909 -6 ☔ View full report in Codecov by Sentry. |
whynowy
reviewed
Jul 17, 2024
whynowy
reviewed
Jul 17, 2024
whynowy
reviewed
Jul 17, 2024
pkg/daemon/server/metrics.go
Outdated
|
|
||
| resp, err := ds.metaDataQuery.GetPipelineWatermarks(ctx, &daemon.GetPipelineWatermarksRequest{Pipeline: ds.pipeline.Name}) | ||
| if err != nil { | ||
| log.Errorw(" failed to calculate lag for pipeline", zap.Error(err)) |
There was a problem hiding this comment.
Suggested change
| log.Errorw(" failed to calculate lag for pipeline", zap.Error(err)) | |
| log.Errorw("Failed to calculate processing lag for pipeline", zap.Error(err)) |
whynowy
reviewed
Jul 17, 2024
whynowy
changed the title
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
whynowy
reviewed
Jul 17, 2024
pkg/daemon/server/metrics.go
Outdated
| }, []string{metrics.LabelPipeline}) | ||
| ) | ||
|
|
||
| func (ds *daemonServer) exposeCTMetrics(ctx context.Context) { |
There was a problem hiding this comment.
We can do it in one routine, right?
pkg/daemon/server/metrics.go
Outdated
|
|
||
| var ( | ||
| currentTimeToWatermark = promauto.NewGaugeVec(prometheus.GaugeOpts{ | ||
| Name: "current_time_compared_to_watermark_milliseconds", |
There was a problem hiding this comment.
We need a better metrics name...
There was a problem hiding this comment.
@yhl25 - this is the metric you want, right?
yhl25
reviewed
Jul 18, 2024
pkg/daemon/server/metrics.go
Outdated
|
|
||
| var ( | ||
| currentTimeToWatermark = promauto.NewGaugeVec(prometheus.GaugeOpts{ | ||
| Name: "current_time_compared_to_watermark_milliseconds", |
pkg/daemon/server/metrics.go
Outdated
Comment on lines
46
to
48
| ) | ||
|
|
||
| func (ds *daemonServer) exposeCTMetrics(ctx context.Context) { |
There was a problem hiding this comment.
please add a comment about what this function does.
pkg/daemon/server/metrics.go
Outdated
| }, []string{metrics.LabelPipeline}) | ||
| ) | ||
|
|
||
| func (ds *daemonServer) exposeCTMetrics(ctx context.Context) { |
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
whynowy
reviewed
Jul 19, 2024
pkg/daemon/server/metrics.go
Outdated
| } | ||
|
|
||
| if maxWM == math.MinInt64 { | ||
| watermarkCmpNow.WithLabelValues(ds.pipeline.Name).Set(0) |
There was a problem hiding this comment.
Don't set it to 0, 0 means there's no difference. Let's do -1.
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
whynowy
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.