Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding feature for retaining fixed number of stale model #13

Merged
merged 7 commits into from
Aug 11, 2022

Conversation

s0nicboOm
Copy link
Contributor

Signed-off-by: s0nicboOm i.kushalbatra@gmail.com

The PR adds a new feature to mlflow code base to maintain fixed number of old models in the Database. (defaults to 5)

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review August 10, 2022 17:40
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #13 (a3f1b4c) into main (47b2519) will increase coverage by 0.65%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   95.50%   96.15%   +0.65%     
==========================================
  Files          25       25              
  Lines         956      962       +6     
  Branches      121      122       +1     
==========================================
+ Hits          913      925      +12     
+ Misses         26       21       -5     
+ Partials       17       16       -1     
Impacted Files Coverage Δ
numalogic/registry/artifact.py 80.00% <100.00%> (ø)
numalogic/registry/mlflow_registry.py 91.52% <100.00%> (+3.13%) ⬆️
numalogic/synthetic/anomalies.py 93.68% <0.00%> (+3.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@s0nicboOm s0nicboOm marked this pull request as draft August 10, 2022 17:42
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm marked this pull request as ready for review August 10, 2022 18:57
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm requested a review from ab93 August 10, 2022 22:36
Copy link
Member

@ab93 ab93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

numalogic/registry/artifact.py Outdated Show resolved Hide resolved
numalogic/registry/mlflow_registry.py Outdated Show resolved Hide resolved
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@ab93 ab93 merged commit 040584f into numaproj:main Aug 11, 2022
@s0nicboOm s0nicboOm deleted the stale_models branch October 21, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants