Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: support full multivariate prometheus fetching #325

Merged
merged 8 commits into from
Nov 27, 2023
Merged

feat!: support full multivariate prometheus fetching #325

merged 8 commits into from
Nov 27, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Nov 17, 2023 •
edited
Loading

  • support multivariate fetching in Prom fetcher
  • fix conf keys used for training and inference
  • fix inf filling (inf values could have caused NaN output before or failed training before)

@ab93
feat!: support mv query in fetch() method
c783ba8 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Nov 17, 2023
@codecov Codecov
Copy link

codecov bot commented Nov 17, 2023 •
edited
Loading

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (c967f20) 94.19% compared to head (fb80cb6) 93.63%.

Files Patch % Lines
numalogic/udfs/trainer/_prom.py 60.00% 14 Missing ⚠️
numalogic/udfs/trainer/_base.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #325      +/-   ##
==========================================
- Coverage   94.19%   93.63%   -0.57%     
==========================================
  Files          76       79       +3     
  Lines        3482     3550      +68     
  Branches      282      289       +7     
==========================================
+ Hits         3280     3324      +44     
- Misses        157      179      +22     
- Partials       45       47       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ab93
add more tests
7be6ddc 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
feat!: separate Prom trainer and Druid trainer
8369510 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: mock method
14e1a66 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: send conf keys instead of request keys to trainer
9d1b999 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: composite key unzip
b761c94 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: use ckeys aligning with config in pre, post and inference vtx
5aa4c13 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93
fix: inf filling
fb80cb6 
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 marked this pull request as ready for review November 27, 2023 17:40
@ab93 ab93 changed the title feat!: support mv query in fetch() method feat!: support full multivariate prometheus fetching Nov 27, 2023
nkoppisetty
nkoppisetty approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@nkoppisetty nkoppisetty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ab93 ab93 merged commit 8b7f45f into main Nov 27, 2023
13 checks passed
@ab93 ab93 deleted the mv-prom-fetch branch November 27, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkoppisetty nkoppisetty nkoppisetty approved these changes

@qhuai qhuai Awaiting requested review from qhuai qhuai is a code owner

@s0nicboOm s0nicboOm Awaiting requested review from s0nicboOm s0nicboOm is a code owner

Assignees

@ab93 ab93

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ab93 @nkoppisetty