Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose port argument to command line #5

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Expose port argument to command line #5

merged 3 commits into from
Apr 7, 2021

Conversation

alexrudd2
Copy link
Member

Closes #3

Still need to test on a real scale.

Don't have commit access to numat/sartorius

@alexrudd2 alexrudd2 marked this pull request as draft March 29, 2021 23:22
@alexrudd2 alexrudd2 marked this pull request as ready for review April 7, 2021 17:15
@alexrudd2
Copy link
Member Author

Works on the basement scale, with both --port and the :port syntax.

@JamesJeffryes JamesJeffryes merged commit 23b2bbf into numat:master Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesJeffryes JamesJeffryes JamesJeffryes left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pass port as command-line argument
2 participants
@alexrudd2 @JamesJeffryes