Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog for the 0.3 series #60

Merged
merged 5 commits into from
Apr 22, 2021
Merged

update changelog for the 0.3 series #60

merged 5 commits into from
Apr 22, 2021

Conversation

esc
Copy link
Member

@esc esc commented Apr 21, 2021

As title

@esc esc added this to the 0.3.0 milestone Apr 21, 2021
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch, few minor things to address else looks good.

CHANGE_LOG Outdated

Contributors
* Brandon T. Willard
* Stuart Archibald
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall adding a patch?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your name appears in the git-log:

 💣 zsh» git --no-pager shortlog -sn 0.3.0dev0..
    24	Valentin Haenel
     7	esc
     4	Brandon T. Willard
     2	stuartarchibald

Probably a merge?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it was merges:

 💣 zsh» git --no-pager shortlog -sn --no-merges 0.3.0dev0..
    24	Valentin Haenel
     4	Brandon T. Willard
     1	esc

CHANGE_LOG Outdated
Importantly, the dynamic generation of the signatures makes numba-scipy now
compatible with multiple SciPy releases simultaneously.

Contributors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line needed here to start a list.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

CHANGE_LOG Outdated

In development
* Dynamic generation of `scipy.special.signatures` (with thanks to Brandon T.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Dynamic generation of `scipy.special.signatures` (with thanks to Brandon T.
* Dynamic generation of ``scipy.special.signatures`` (with thanks to Brandon T.

double backticks else you just get italics.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

CHANGE_LOG Outdated
Willard)
* Github Actions CI

Importantly, the dynamic generation of the signatures makes numba-scipy now
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Importantly, the dynamic generation of the signatures makes numba-scipy now
Importantly, the dynamic generation of the signatures now makes ``numba-scipy``

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes, a "germanism".

@esc esc mentioned this pull request Apr 22, 2021
10 tasks
Copy link
Contributor

@stuartarchibald stuartarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch.

@esc
Copy link
Member Author

esc commented Apr 22, 2021

@stuartarchibald thanks for the review, release will commence now.

@esc esc merged commit bd99bb6 into numba:master Apr 22, 2021
@esc esc deleted the change_log_0.3 branch April 22, 2021 14:54
@sklam sklam mentioned this pull request Jun 29, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants