Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The definition of Schwefel function seems inconsistent with the implementation #837

Closed
NDManh opened this issue Mar 15, 2016 · 8 comments
Closed
Assignees

Comments

@NDManh
Copy link
Collaborator

NDManh commented Mar 15, 2016

If we respect to the implementation :

  1. The x_opt in the formula z = 100(Lambda^10(z^hat - x_opt) + x_opt) should be 2*abs(x_opt).
  2. The formula - frac{1}{D} sum(...) should be - frac{1}{100D} sum(...).

(Thanks Niko, I've updated some expressions such that the context is more clear)

@nikohansen
Copy link
Contributor

nikohansen commented Mar 15, 2016

Thanks for spotting these! There is a third mistake in the description: x_i^opt in the second bullet point must be 2 * abs(x_i^opt) as well. It's the same problem as with 1), it's a confusion of what x_opt is supposed to mean in the given context (\hat x_opt seems asked for). Re 2), I guess this might also cancel the 100 in front of the penalty term, not sure though...

@nikohansen
Copy link
Contributor

nikohansen commented Jul 26, 2016

Also: in f23 and f24 "+ f_opt" is missing and for f21/22 we should add the reference M. Gallagher and B. Yuan. A General-Purpose Tunable Landscape Generator. IEEE Transactions on Evolutionary Computation 10(5):590-603, 2006.

@brockho
Copy link
Contributor

brockho commented Nov 15, 2017

I started to have a look at the above as well as at #1266.

The only unclear thing was whether the 100 should appear in front of the penalty term or not. It is not obvious to see that the implementation follows the LaTeX definition here but after checking the code carefully, I am convinced that @NDManh was correct in the sense that the 100 should stay in the LaTeX definition in front of the penalty term to coincide with the implementation.

The coco svn repository has now the updated LaTeX code (in coco/BBOB/doc/latexFunctions/) and it will be nice if somebody can check (with me) whether everything is actually correct now in the pdf. We then have to update the HAL version and the links from the web pages.

@nikohansen
Copy link
Contributor

nikohansen commented Mar 30, 2018

It seems I spotted another mistake: Section 2.7, Step-Ellipsoid function, if \hat z_i > 0.5 must read if |\hat z_i| > 0.5, as correctly implemented here.

@brockho
Copy link
Contributor

brockho commented Mar 30, 2018

Nice catch!

@nikohansen
Copy link
Contributor

There is another small glitch in the definition of the Rosenbrock function f8: x_opt is chosen in [-3, 3]^n. This should have been mentioned explicitly in the definition.

@nikohansen
Copy link
Contributor

All above errors are now addressed in the source file.

@nikohansen
Copy link
Contributor

The fixed document were uploaded to HAL and to http://coco.gforge.inria.fr/downloads/download16.00 and are used at the COCO gforge home and in the links at the latest old release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants