This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
WIP: Implement pagination headers #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramnes
reviewed
Nov 28, 2018
Yep, it really does! Also, check the Travis build, it's failing. |
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
from
0b58418
to
7addedc
Compare
trubesv
changed the title
trubesv
force-pushed
the
feature/pagination_headers
branch
from
7addedc
to
7526b7b
Compare
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
from
7526b7b
to
91a9363
Compare
Pull Request Test Coverage Report for Build 130
💛 - Coveralls |
ramnes
reviewed
Nov 28, 2018
tests/json.py
Outdated
| response = client.get("/") | ||
| assert response.status_code == 200 | ||
|
|
||
| assert "X-Total-Count" in response.headers |
There was a problem hiding this comment.
Suggested change
| assert "X-Total-Count" in response.headers | |
| assert response.headers["X-Total-Count"] == 3 |
There was a problem hiding this comment.
Do we really need both tests then?
There was a problem hiding this comment.
Right. But then a similar test should be done in tests/app.py, because we want the headers mode to work also with the non-json Stupeflask version.
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
2 times, most recently
from
4fdb4a2
to
719bc27
Compare
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
from
719bc27
to
3c992cf
Compare
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
from
3c992cf
to
00eb794
Compare
trubesv
changed the title
|
Concerning the current implementation, i tried to stick to the RFC linked by @tobes. Don't you think it's the best thing to do ? |
ramnes
reviewed
Nov 28, 2018
trubesv
force-pushed
the
feature/pagination_headers
branch
2 times, most recently
from
af1196e
to
8ba04d7
Compare
|
Don't we want the dict values in the body to only contain the links, without the |
trubesv
force-pushed
the
feature/pagination_headers
branch
3 times, most recently
from
9d544ef
to
f047dc9
Compare
|
PyMongo already handles that for the |
|
I think we should simply not offer the relatives links if we're on an edge. |
trubesv
force-pushed
the
feature/pagination_headers
branch
from
f047dc9
to
77f6e0d
Compare
trubesv
force-pushed
the
feature/pagination_headers
branch
2 times, most recently
from
b3091dc
to
f076ac7
Compare
Fixes #19 TODO: - Implement & test header Link for bare Flask app
trubesv
force-pushed
the
feature/pagination_headers
branch
from
f076ac7
to
81347d0
Compare
ramnes
force-pushed
the
master
branch
2 times, most recently
from
deca4d9
to
1690fda
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I PR this as apparently there is a need (@trubesv ).
At least we can discuss the implementation.