Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed use of "==" operator to Class.isAssignableFrom method #514

Merged
merged 3 commits into from
Mar 26, 2017
Merged

Changed use of "==" operator to Class.isAssignableFrom method #514

merged 3 commits into from
Mar 26, 2017

Conversation

Hopding
Copy link
Contributor

@Hopding Hopding commented Mar 11, 2017

Fixes #513. This PR changes use of == operator to Class.isAssignableFrom method in Layer.java.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 83.114% when pulling 77889c9 on Hopding:robust-classifier-type-comparison-513 into bec5f6f on numenta:master.

@cogmission
Copy link
Collaborator

@Hopding Hi, what I usually do at this point is follow the coveralls link and review the classes there that can use some "coverage", and create new tests until coveralls is happy. Something we all go through I'm afraid because coveralls isn't perfect?

@Hopding
Copy link
Contributor Author

Hopding commented Mar 16, 2017

@cogmission Ah, I'm afraid I hadn't realized the Coveralls check failed. Thanks for bringing that to my attention. I'll take a look and fix it as soon as I get a chance.

@Hopding
Copy link
Contributor Author

Hopding commented Mar 19, 2017

Haven't forgotten about this. Been busy, but should have some time for this soon 👍

@cogmission
Copy link
Collaborator

No worries. I have lot's going on personally too, so I can relate...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 83.208% when pulling ed46d0e on Hopding:robust-classifier-type-comparison-513 into bec5f6f on numenta:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 83.211% when pulling ed46d0e on Hopding:robust-classifier-type-comparison-513 into bec5f6f on numenta:master.

@Hopding
Copy link
Contributor Author

Hopding commented Mar 26, 2017

@cogmission There, should be all better now 👍 My apologies for the delay.

@cogmission
Copy link
Collaborator

@Hopding No need to apologize, I knew you'd get around to it. Nice Tests!

@cogmission cogmission merged commit 3130604 into numenta:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants