Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Distribute column over inputs uniformly in mapPotential #816

Merged
merged 6 commits into from
Apr 21, 2014

Conversation

chetan51
Copy link
Contributor

Requesting review: @subutai @iandanforth

Fixes #709

Must first merge numenta/nupic.core-legacy#75, and then point this PR to the new core before merging it.

@breznak
Copy link
Member

breznak commented Apr 15, 2014

👍 thanks guys!
Btw, can you give a simple example where the old code would make the hiccups?

@chetan51
Copy link
Contributor Author

@breznak Any case where there are more inputs than columns, and the potential radius is small.

@breznak
Copy link
Member

breznak commented Apr 15, 2014

Gosh, I see it now! Thanks @chetan51 for fixing, and @iandanforth for discovering!! Heck, how could it even work without it? (i guess inh/boosting had to do hard work to spread inputs evenly?)

Btw2, from what I see the distribution of input indices for a column is uniform, while theory shows why it should be normal distr. Should there be a new bug for that?

@chetan51
Copy link
Contributor Author

@breznak For most current use-cases, the SP is used without topology. That's why the SP "works" without this fix.

As for uniform vs. normal distribution of columns over inputs, I'm planning on experimenting with a normal / gaussian distribution for when topology is enabled. This will be part of a greater refactor to support N-dimensional topology. Until then!

@breznak
Copy link
Member

breznak commented Apr 15, 2014

👍 can't wait to see nD topology working! :)

@iandanforth
Copy link
Contributor

👍

@chetan51
Copy link
Contributor Author

Ready for merge!

rhyolight added a commit that referenced this pull request Apr 21, 2014
Distribute column over inputs uniformly in mapPotential
@rhyolight rhyolight merged commit 6ab3805 into numenta:master Apr 21, 2014
@chetan51 chetan51 deleted the issue-709 branch April 21, 2014 22:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spatial Pooler column connection distribution is unexpected
4 participants