Skip to content
This repository has been archived by the owner on Sep 1, 2023. It is now read-only.

Independent Build Process #32

Closed
wants to merge 4 commits into from
Closed

Independent Build Process #32

wants to merge 4 commits into from

Conversation

david-ragazzi
Copy link
Contributor

This commit includes the compilation of the dynamic/static libraries
that compose nupic.core. They are generated by default on
nupic.core/build/release folder, however any user could change its
destination using cmake -DPROJECT_BUILD_RELEASE_DIR=… or cmake -DPROJECT_BUILD_TEMP_DIR=… command line.
Thought this option, Travis at nupic repo will compile the static
libraries and put them on /externalfolder.

Note that neither HtmTest not TestEverything were included, they still
are hybrid and Python tests need be removed from them.

David Ragazzi and others added 3 commits March 1, 2014 21:37
This commit includes the compilation of the dynamic/static libraries
that compose nupic.core. They are generated by default on
nupic.core/build/release folder, however any user could change its
destination using "cmake -DPROJECT_BUILD_RELEASE_DIR=…" command line.
Thought this option, Travis at nupic repo will compile the static
libraries and put them on /external folder.
Note that neither HtmTest not TestEverything was included, they still
are hybrid and Python test need be removed from them.
@rhyolight
Copy link
Member

Alright! Great job!

@rhyolight
Copy link
Member

@david-ragazzi I have a couple of questions now that I've had a chance to look through the changes.

The README says cmake $REPOSITORY/src, but there is no src dir yet. Are you planning on making a src dir as a part of #15?

Also, do we still need:

before_install:
  - git clone https://github.com/numenta/nupic-linux64.git
  - (cd nupic-linux64 && git reset --hard 9e4df07ee03184d670a8801b76f206785e2a8b2e)
  - source nupic-linux64/bin/activate

in .travis.yml? Or are all the dependencies we need in the externals folder?

@david-ragazzi
Copy link
Contributor Author

Hi Matt,

The README says cmake $REPOSITORY/src, but there is no src dir yet. Are you planning on making a src dir as a part of #15?

Yes, exactly. As nupic.core is under constuction the Readme file can have this instruction in order to avoid a future change.

Also, do we still need:

before_install:

in .travis.yml? Or are all the dependencies we need in the externals folder?

All the dependencies we need are in the externals folder.. We can remove this.. :-)

Please, don't merge now, I will change some things in CMake file related to nupic.core dynamic library..

@rhyolight
Copy link
Member

Thanks, looking so far! :)

Sent from my MegaPhone

On Mar 2, 2014, at 3:05 PM, DavidRagazzi notifications@github.com wrote:

Hi Matt,

The README says cmake $REPOSITORY/src, but there is no src dir yet. Are you planning on making a src dir as a part of #15?

Yes, exactly. As nupic.core is under constuction the Readme file can have this instruction in order to avoid a future change.

Also, do we still need:

before_install:

git clone https://github.com/numenta/nupic-linux64.git
(cd nupic-linux64 && git reset --hard 9e4df07)
source nupic-linux64/bin/activate
in .travis.yml? Or are all the dependencies we need in the externals folder?

All the dependencies we need are in the externals folder.. :-)

Please, don't merge now, I will change some things in CMake file related to nupic.core dynamic library..


Reply to this email directly or view it on GitHub.

@david-ragazzi
Copy link
Contributor Author

Ok..I fixed cmake file. You can merge after your review my last PR that replaced this.

Sent from my iPhone

On 02/03/2014, at 22:34, Matthew Taylor notifications@github.com wrote:

Thanks, looking so far! :)

Sent from my MegaPhone

On Mar 2, 2014, at 3:05 PM, DavidRagazzi notifications@github.com wrote:

Hi Matt,

The README says cmake $REPOSITORY/src, but there is no src dir yet. Are you planning on making a src dir as a part of #15?

Yes, exactly. As nupic.core is under constuction the Readme file can have this instruction in order to avoid a future change.

Also, do we still need:

before_install:

git clone https://github.com/numenta/nupic-linux64.git
(cd nupic-linux64 && git reset --hard 9e4df07)
source nupic-linux64/bin/activate
in .travis.yml? Or are all the dependencies we need in the externals folder?

All the dependencies we need are in the externals folder.. :-)

Please, don't merge now, I will change some things in CMake file related to nupic.core dynamic library..


Reply to this email directly or view it on GitHub.

Reply to this email directly or view it on GitHub.

rcrowder added a commit that referenced this pull request Dec 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants