-
Notifications
You must be signed in to change notification settings - Fork 277
Conversation
This commit includes the compilation of the dynamic/static libraries that compose nupic.core. They are generated by default on nupic.core/build/release folder, however any user could change its destination using "cmake -DPROJECT_BUILD_RELEASE_DIR=…" command line. Thought this option, Travis at nupic repo will compile the static libraries and put them on /external folder. Note that neither HtmTest not TestEverything was included, they still are hybrid and Python test need be removed from them.
Alright! Great job! |
@david-ragazzi I have a couple of questions now that I've had a chance to look through the changes. The README says Also, do we still need:
in |
Hi Matt,
Yes, exactly. As nupic.core is under constuction the Readme file can have this instruction in order to avoid a future change.
All the dependencies we need are in the externals folder.. We can remove this.. :-) Please, don't merge now, I will change some things in CMake file related to nupic.core dynamic library.. |
Thanks, looking so far! :) Sent from my MegaPhone
|
Ok..I fixed cmake file. You can merge after your review my last PR that replaced this. Sent from my iPhone
|
This commit includes the compilation of the dynamic/static libraries
that compose
nupic.core
. They are generated by default onnupic.core/build/release
folder, however any user could change itsdestination using
cmake -DPROJECT_BUILD_RELEASE_DIR=…
orcmake -DPROJECT_BUILD_TEMP_DIR=…
command line.Thought this option, Travis at
nupic
repo will compile the staticlibraries and put them on
/external
folder.Note that neither
HtmTest
notTestEverything
were included, they stillare hybrid and Python tests need be removed from them.