This repository has been archived by the owner on Sep 1, 2023. It is now read-only.
workaround strerror_r ignoring return value warning #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because of Werror, just a hack. Affected: ubuntu 13.04 gcc
This reverts commit faa7ac7.
|
here is the manpage http://man7.org/linux/man-pages/man3/strerror.3.html I've tried using the POSIX (more portable) version, but it wouldn't do without further changes. So keeping as is for now. |
|
@scottpurdy Please review. |
|
I must be missing something in the manpage that explains this but why are we saving the return value to local variable |
|
That was the point of this PR (fix warning which errors with Werror). We |
scottpurdy
added a commit
that referenced
this pull request
Mar 17, 2014
workaround strerror_r ignoring return value warning
utensil
referenced
this pull request
in david-ragazzi/nupic.core
Apr 4, 2014
pettitda
pushed a commit
to pettitda/nupic.core
that referenced
this pull request
Jun 3, 2016
Updating master
breznak
added a commit
to breznak/nupic.core
that referenced
this pull request
Jul 31, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix (workaround) issue #39
because of Werror, just a hack. Affected: ubuntu 13.04 gcc