Changes to make it compatible with python 3.7 #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasosouza
changed the title
lucasosouza
commented
Jun 28, 2021
| @@ -2,7 +2,8 @@ | |||
|
|
|||
| import torch.nn | |||
|
|
|||
| from typing import Callable, Literal | |||
| from typing import Callable | |||
| from typing_extensions import Literal | |||
There was a problem hiding this comment.
The man himself had an answer to this issue
lucasosouza
commented
Jun 28, 2021
| @@ -20,5 +20,6 @@ | |||
| # | |||
| # ------------------------------------------------------------------------------ | |||
| # Requirements specific to learning by disagreement project | |||
| opencv-python | |||
There was a problem hiding this comment.
For some reason it is not being installed by real_robots, although it is a requirement on that lib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vkakerbeck I fixed a bug in requirements and made minor changes to adapt it to python 3.7. Can you please install a fresh environment with python 3.7 and try again, to see if any of those two errors come up (EOF and segmentation error). Here are the steps to create
conda create -n new_environment_name python=3.7conda activate new_environment_nameIn nta/nupic.embodied:
pip install -e .In nta/nupic.embodied/projects/robot_arm:
pip install -r requirements.txtIf the errors appear, please take a screenshot as well and send me along with the experiment name so I can try to replicate. An idea is to create an issue here in github with the details so we can track it.
Also if the installation steps above fail, please let me know so I can adjust accordingly. I will make it part of the yaml file for now, and later incorporate it into the AMI.
Meanwhile I will also try to run local with 3.8 to see if I can replicate.
edit: also added an initial Readme with basic instructions on how to install and run it