Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update design system 1.0.0 #143

Merged
merged 19 commits into from
May 18, 2021
Merged

Conversation

estellecomment
Copy link
Contributor

No description provided.

Copy link
Member

@jdauphant jdauphant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est normal que tu ne commit pas le "package-lock.json" ?

@estellecomment estellecomment marked this pull request as ready for review May 17, 2021 15:31
@estellecomment
Copy link
Contributor Author

@astranchet tu veux bien faire la review ? C'est toi l'experte du DS :)
Il ne devrait pas y avoir de gros changements visibles par rapport à la version en prod, à part le bouton pour changer de thème.
J'ai arrangé qq alignements qui me paraissaient bizarres (ya moyen qu'ils etaient deja bizarre avant l'upgrade du DS ! :D).
J'ai testé normalement sur mobile aussi.

@estellecomment
Copy link
Contributor Author

C'est normal que tu ne commit pas le "package-lock.json" ?

si si, c'est fait (je l'ai refait du coup)

@estellecomment estellecomment merged commit 13e5758 into main May 18, 2021
@estellecomment estellecomment deleted the chore/update-design-system-1.0.0 branch May 18, 2021 13:42
@jdauphant
Copy link
Member

Cool on peut déployer en prod et on aura Sentry au passage en prod !

@estellecomment
Copy link
Contributor Author

c'est deja fait !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants