-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a NumPy Team #205
Add a NumPy Team #205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shaloo, the output looks pretty good!
Code wise there's some cleanups to do to make this easier to maintain. A lot of committed files are unneccesary. I propose to aim for the following structure:
scripts/gallery/numpy_team.py
scripts/gallery/numpy_team.yml
scripts/gallery/cache/numpy_team.context
content/en/team.md
layouts/partials/team_gallery.html
As far as I can tell, that's all you need. And then the page would end up at /team
rather than /gallery/team
What about _templates? Those are used by Jinja2 to spit out html (static html with no variables unlike partials). Or are you suggesting we use partial/team.html as the template for Jinja2 translations? |
As I commented on #45 (comment), I missed the The duplication of the CSS and images would still be good to fix though, that really does look unnecessary and it will go out of sync as soon as the other |
Done. At present, master seems to have some issues - the build shows empty page so I have not been able to validate whether modifying team.md in content/en/ folder with the one I am using (that has Jinja directives) will play well with Hugo. Once the base master builds successfully without the changes I have made in scripts/gallery area, I will issue a PR. The script reorg as suggested above minus team.md relocation to suggested dir has been validated - both with GitHub as well as cache/numpy_team.context data. |
All these are addressed now other than last two bullets. Those will be part of #213 which will remove jinja2 dependency. |
…referenced from about page in Hugo
Also fix some minor things.
I removed Would be nice if there was an The current cache in this PR is incomplete, I'll see if GitHub lets me update it later today. |
The rest of changes look good, my earlier comments were addressed. |
One other thing gh-213 will fix is that the current page doesn't have a navbar. Not a blocker though. The gallery looks good, and the current cache is updated. The GitHub rate limiting behavior is such that a single run of this script is fine, but a couple in a row is not. If this grows a lot, we may have to add an incremental mode at some point. Merging, thanks @shaloo! |
@@ -0,0 +1,1059 @@ | |||
ignore_io_errors: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file supposed to be committed? The fact it dupicates the yaml makes me think that perhaps it shouldn't be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, see the discussion above - it's the output of retrieving from the GitHub API, which we don't want to do all the time.
I deleted the |
NumPy Team gallery added, script to generate gallery added.
Fixes gh-45
Deployed URL
http://numpy-205.surge.sh/