Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEP: Drop Python2 support. #10006

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Conversation

charris
Copy link
Member

@charris charris commented Nov 12, 2017

[ci skip]

I put a 1.14 milestone on this as I would like to include a reference in the release notes.

@charris charris added this to the 1.14.0 release milestone Nov 12, 2017

If you are a NumPy user who requires ongoing Python2 support in 2020 or later,
then please contact your vendor. If you are a vendor who wishes to continue to
support NumPy on Python2 in 2020+, please get in touch; ideally we'd like you
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a good place to add an link of some form (e.g., an email address for a core developer who could coordinate)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would just be the mailing list, I guess? I dunno, if you can't figure out how to contact the project then maybe you shouldn't be selling commercial support for numpy :-).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

to get involved in maintaining the LTS before it actually hits end of life so
that we can make a clean handoff.

To minimize disruption, running ``pip install numpy`` on Python 2 will continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matthias Bussonier suggested to make it "should continue", have no clue myself, doubt it matters too much.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2n's but yes :-) thanks. From experience with IPython many Python 2 users have an old verision of pip. Here is my download statistics analysis for IPython. Though with a good error message in setup.py (please upgrade pip) it tend to get solved fast.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make that suggestion in the next release? It can't hurt to have it done before Python2 is dropped.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference, the pip version should be >= 9.

@seberg
Copy link
Member

seberg commented Nov 13, 2017

Anyway, I am good with putting this in with or without modifications. Should wait a week more or so to give everyone a chance to protest maybe.

Copy link
Contributor

@mhvk mhvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all OK to me - most important is that the dates are clear, and they are.

@Carreau
Copy link
Contributor

Carreau commented Nov 13, 2017

Just as a thought, if you bump version number and get a LTS you should likely have version 2.x be LTS and version 3.x be python 3 only.

@charris
Copy link
Member Author

charris commented Nov 14, 2017

I'm putting this in now. We can update it if there are future changes.

@charris charris merged commit 26dd6b8 into numpy:master Nov 14, 2017
@charris charris deleted the drop-python2.7-support branch November 14, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants