Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python 2 #1830

Closed
jhamman opened this issue Jan 15, 2018 · 7 comments
Closed

Drop support for Python 2 #1830

jhamman opened this issue Jan 15, 2018 · 7 comments

Comments

@jhamman
Copy link
Member

jhamman commented Jan 15, 2018

When do we want to drop Python 2 support for Xarray. For reference, Pandas has a stated drop date for Python 2 of the end of 2018 (this year) and Numpy is slightly later and includes an incremental depreciation, final on Jan. 1, 2020.

We may also consider signing this pledge to help make it clear when/why we're dropping Python 2 support: http://www.python3statement.org/

xref: pandas-dev/pandas#18894, numpy/numpy#10006, python3statement/python3statement.github.io#11

@shoyer
Copy link
Member

shoyer commented Jan 15, 2018

My inclination would be to follow the lead of pandas here, since it's unlikely to make sense to update xarray without its dependencies. So I guess end of 2018 makes sense?

@jhamman
Copy link
Member Author

jhamman commented Jan 31, 2018

I've just put up a PR on the python3statement repo. I've tentatively also listed 2019-01-01 as a possible target for Xarray 1.0, coincident with dropping Python2, but am now thinking we may need a larger discussion before that comes to any certainty. Anyhow, please take a look at python3statement/python3statement.github.io#102.

@shoyer
Copy link
Member

shoyer commented Jan 31, 2018

My inclination would be to save 1.0 until xarray's data model is stable, which probably means after #1603. If the timing works out for dropping Python 2 support that would be great, but I wouldn't want to force it.

@jhamman
Copy link
Member Author

jhamman commented Jan 31, 2018

@pydata/xarray - any objections to the timeline here? We will need to close this before python3statement/python3statement.github.io#102 can be merged.

@shoyer
Copy link
Member

shoyer commented Jan 31, 2018

I don't object to the timeline, but I don't think we're ready to commit to supporting Python 2 for all 0.X releases and stopping it with 1.0. The particular version number feels premature to me.

@jhamman
Copy link
Member Author

jhamman commented Jan 31, 2018

Great. No argument there. I'll adjust the PR on the python3statement to reflect that.

@fmaussion
Copy link
Member

I fully agree with the proposed changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants