Improve documentation of numpy.ma.filled #26481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
reviewed
May 20, 2024
numpy/ma/core.py
Outdated
| Return input as an array with masked data replaced by a fill value. | ||
| Return a copy of `a`, with masked values replaced by a fill value. | ||
| However, if there are no masked values to fill, `a` will be returned | ||
| instead as an ndarray. |
There was a problem hiding this comment.
Is it "a's data will be returned" or "a copy of a will be returned"?
There was a problem hiding this comment.
Also note that this information shouldn't be part of the initial sentence, but rather the following paragraph.
karthikkaiplody
changed the title
rossbar
reviewed
May 24, 2024
[skip azp] [skip actions] [skip cirrus]
|
Thanks @karthikkaiplody, @rossbar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9716