feat: simplify pipeline model #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zowoq this is my first attempt at making it easier to configure the ordering of formatters and make it easier to handle nix-community/infra#1266 (comment) I'm keen to get your feedback. |
brianmcgee
force-pushed
the
feat/better-concurrency-model
branch
from
734bf50
to
01ab21a
Compare
brianmcgee
changed the title
zimbatm
approved these changes
May 24, 2024
|
This looks good, thank you! |
brianmcgee
force-pushed
the
feat/better-concurrency-model
branch
from
b003614
to
82518f6
Compare
For each path we determine the list of formatters that are interested in formatting it. From there, we sort the list of formatters first by priority (lower value, higher priority) and then by name (lexicographically). With this information we create a batch key which is based on the unique sequence of formatters. When enough paths with the same sequence is ready we apply them in order to each formatter. By default, with no special configuration, this model guarantees that a given path will only be processed by one formatter at a time. If a user wishes to influence the order in which formatters are applied they can use the priority field. Signed-off-by: Brian McGee <brian@bmcgee.ie>
brianmcgee
force-pushed
the
feat/better-concurrency-model
branch
from
82518f6
to
ce14ee8
Compare
|
@zimbatm did some cleanup and updated the docs. |
Merged
zimbatm
approved these changes
May 26, 2024
|
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 06f15f4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each path we determine the list of formatters that are interested in formatting it. From there, we sort
the list of formatters first by priority (lower value, higher priority) and then by name (lexicographically).
With this information we create a batch key which is based on the unique sequence of formatters. When enough paths with the same sequence is ready we apply them in order to each formatter.
By default, with no special configuration, this model guarantees that a given path will only be processed by one formatter at a time.
If a user wishes to influence the order in which formatters are applied they can use the priority field.
TODO
Signed-off-by: Brian McGee brian@bmcgee.ie