-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documentation of the CurrentContext object #804
Improve documentation of the CurrentContext object #804
Conversation
@dotnet-policy-service agree [company="On Test Automation"] |
@dotnet-policy-service agree company="On Test Automation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @basdijkstra! This is the kind of thing I'm hoping to eventually get automatically from the source when we hook docfx up but for now this is really a big help.
Going to run it by @OsirisTerje / @manfred-brands to double-check correctness but LGTM
You're welcome, @SeanKilleen! By the way, this is linked to nunit/nunit#4497 in case you hadn't seen that. Forgot to mention that in the PR message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for this!
This PR improves the documentation for the
CurrentContext
object by listing all of its properties, including clarification on only failed assertions being retained as anAssertionResult
.