Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct typo (missing semicolon) #840

Merged
merged 1 commit into from
Nov 26, 2023
Merged

fix: Correct typo (missing semicolon) #840

merged 1 commit into from
Nov 26, 2023

Conversation

mikkelbu
Copy link
Member

No description provided.

@mikkelbu mikkelbu marked this pull request as ready for review November 26, 2023 10:14
manfred-brands
manfred-brands approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@manfred-brands manfred-brands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if such items could be detected in builds, but snapshot examples are often partial pieces of code.

@OsirisTerje
Copy link
Member

It can, if the code is placed in the snippets parts. But, I see it is more suitable for longer examples.

@SeanKilleen
Copy link
Member

These will eventually be moved to snippets. For now, thanks for this fix!

@SeanKilleen SeanKilleen merged commit 1aa400a into master Nov 26, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2023
@SeanKilleen
fix: Correct typo (missing semicolon) (#840) 1aa400a
236e21c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manfred-brands manfred-brands manfred-brands approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikkelbu @OsirisTerje @SeanKilleen @manfred-brands