Setupfixture fixes #917
Merged
Setupfixture fixes #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeanKilleen
reviewed
Mar 1, 2024
SeanKilleen
reviewed
Mar 1, 2024
SeanKilleen
reviewed
Mar 1, 2024
SeanKilleen
reviewed
Mar 1, 2024
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
Co-authored-by: Sean Killeen <SeanKilleen@gmail.com>
|
Thanks @SeanKilleen for the commit suggestions! Always appreciated! |
|
@OsirisTerje thanks for doing the hard part! |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 1, 2024
* setupfixture fixes * setupfixture fixes * Update docs/articles/nunit/writing-tests/attributes/setupfixture.md Co-authored-by: Sean Killeen <SeanKilleen@gmail.com> * Update docs/articles/nunit/writing-tests/attributes/setupfixture.md Co-authored-by: Sean Killeen <SeanKilleen@gmail.com> * Update docs/articles/nunit/writing-tests/attributes/setupfixture.md Co-authored-by: Sean Killeen <SeanKilleen@gmail.com> * setupfixture fixes --------- Co-authored-by: Sean Killeen <SeanKilleen@gmail.com> e1be1c7
chm-tm
reviewed
Apr 16, 2024
Comment on lines
+80
to
+86
| > [!NOTE] | ||
| > Filtering on `SetUpFixture`s | ||
|
|
||
| A `SetUpFixture` is normally not used for filtering tests. However, if that is done, one should be aware that a | ||
| `SetUpFixture` encapsulates all tests to which it belongs. | ||
| If placed in a namespace it will encapsulate all tests in that namespace and contained namespaces. | ||
| If placed on the assembly level, it will encapsulate all tests in the assembly. |
There was a problem hiding this comment.
Was this your intention to place those explanations about filtering outside the note block?
There was a problem hiding this comment.
No, want to fix it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying setupfixture documentation based on questions in issue nunit/nunit#4268
Also fixes Issue #819