Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate NuGet Restore for Appveyor build #525

Merged
merged 1 commit into from
Jan 5, 2019
Merged

Conversation

ChrisMaddock
Copy link
Member

Following on from: #517, @IlyaFinkelshteyn from the @appveyor team found this solution, which will allow us to continue using the current appveyor image, and our builds not to fail when the "Previous" image next changes.

The core issue seems to be this one: NuGet/Home#7414, which Appveyor are tracking via: appveyor/ci#2787

@ChrisMaddock ChrisMaddock added this to the 3.10 milestone Jan 5, 2019
@ChrisMaddock ChrisMaddock self-assigned this Jan 5, 2019
Copy link
Member

@mikkelbu mikkelbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like a hack 😄, but not worse than "Previous", so let us live with it for now.

@mikkelbu mikkelbu merged commit 30cf76e into master Jan 5, 2019
@mikkelbu mikkelbu deleted the ChrisMaddock-patch-1 branch January 5, 2019 21:46
@ChrisMaddock
Copy link
Member Author

ChrisMaddock commented Jan 5, 2019

Definitely hacky - but better than 'previous' because 'previous' will break on the next appveyor update, when the current build becomes the previous. Fingers crossed, this 'fix' will keep working indefinitely. 🙂

@IlyaFinkelshteyn
Copy link

@gep13, @devlead maybe this (switch to nuget instead of msbuild to restore packages) can be done somehow within Cake for it to look less hacky?

@devlead
Copy link

devlead commented Jan 5, 2019

@IlyaFinkelshteyn sure one could have a Restore task in the script that the build task depends on.

@ChrisMaddock
Copy link
Member Author

Thanks both! Will take a look. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants