Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.DotNet.InternalAbstractions dependency fully (Except .NET Standard 1.6) #859

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

ChrisMaddock
Copy link
Member

Fixes #837, and corrects an error I made in an earlier PR.

@CharliePoole - apologies, this will cause two small conflicts with your PR to remove the .NET Standard 1.6 builds. I just wanted to fix the errors for the 3.12 release, and then we can remove fully after.

@CharliePoole
Copy link
Collaborator

No problem, I'll rebase and resolve them for afterwards.

Copy link
Collaborator

@CharliePoole CharliePoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me...

@CharliePoole CharliePoole merged commit edcbd83 into master Jan 11, 2021
@CharliePoole CharliePoole deleted the issue-837 branch January 11, 2021 01:52
@ChrisMaddock ChrisMaddock restored the issue-837 branch January 16, 2021 22:07
@ChrisMaddock ChrisMaddock deleted the issue-837 branch January 16, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully remove Microsoft.Dotnet.InternalAbstractions dependency
2 participants