Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable custom test output result file #1112

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

Lorilatschki
Copy link
Contributor

When using the TestOutputXmlFileNameWithoutExtension run setting property, the client can define a custom result file name rather than the name of the assembly to be tested

…up a custom result file name rather than the name of the assembly to be tested
@Lorilatschki
Copy link
Contributor Author

@dotnet-policy-service agree

@Lorilatschki
Copy link
Contributor Author

@OsirisTerje this will enable the custom result file definition. The docs need to be adapted due to the newly introduced property TestOutputXmlFileNameWithoutExtension. After merging and adapting the docs, the docs/issue/592 can be closed.

@OsirisTerje
Copy link
Member

Looks good, but TestOutputXmlFileNameWithoutExtension is a very long propertyname. I think the WithoutExtension can be skipped. It can be stated in the docs, and if they don't read it the worst that will happen is they will have a file named whatever.xml.xml.

@OsirisTerje
Copy link
Member

Moved the docs item over here, since it is adapter docs, at #1114

@Lorilatschki
Copy link
Contributor Author

Looks good, but TestOutputXmlFileNameWithoutExtension is a very long propertyname. I think the WithoutExtension can be skipped. It can be stated in the docs, and if they don't read it the worst that will happen is they will have a file named whatever.xml.xml.

Will adjust it.

Copy link
Member

@OsirisTerje OsirisTerje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OsirisTerje OsirisTerje merged commit b3b5f4a into nunit:master Aug 3, 2023
3 checks passed
@OsirisTerje
Copy link
Member

Fixes ##1114

@OsirisTerje
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants