Add extension for app return type, including test cases.

[troelsselch]

I have added a simple return type extension for the app() helper.
Fully qualified classes will be resolved to the class itself. Unknown types, e.g. 'sentry' or 'db', will be resolved to MixedType.

This will allow checking for method calls directly on app(), so that e.g.

/** @var Handler $handler */
$handler = app(Handler::class);
$handler->capture($exception);

can be simplified to

app(Handler::class)->capture($exception);

and still be verified by larastan.

[nunomaduro]

I don't see a reason for having a MixedType here. You should resolve things out of the container, and return the type of the resolved value.

[canvural]

Hi,

Thank you for the PR! I left some comments.

[troelsselch]

Thanks for the feedback. I have cleaned up the code and try to resolve String_ values from the container.

I still have two cases with MixedType():

• if $expr is not instance of ClassConstFetch, and
• if $expr->class is instance of Name

In the first case I cannot see another option.
In the latter case I could process the $expr->class and $expr->name and try to resolve that in the container. However, that requires more reflection checking in case class is e.g. self.

What are your thoughts on this?

[troelsselch]

I have rebased and updated to be using ErrorType and NeverType as suggested.

Updated

[canvural]

Thank you @troelsselch ! Good first contribution!