[16.0][MIG] lighting_portal_connector: Migration to 16.0 #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eantones
added
work in progress
changes requested
and removed
to review
KNVx
force-pushed
the
16.0-mig-lighting_porta_connector
branch
3 times, most recently
from
70f2b31
to
684bf67
Compare
KNVx
force-pushed
the
16.0-mig-lighting_porta_connector
branch
from
684bf67
to
c29f9d8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #28 +/- ##
=======================================
Coverage ? 36.00%
=======================================
Files ? 6
Lines ? 100
Branches ? 19
=======================================
Hits ? 36
Misses ? 64
Partials ? 0 ☔ View full report in Codecov by Sentry. |
KNVx
force-pushed
the
16.0-mig-lighting_porta_connector
branch
from
c29f9d8
to
77a6f3a
Compare
eantones
requested changes
Jan 9, 2024
|
|
||
| def update(self): | ||
| self.ensure_one() | ||
| if not self.env.user.has_group( | ||
| "lighting_portal_connector.portal_connector_group_manager" | ||
| ): | ||
| tdelta = fields.datetime.now() - fields.Datetime.from_string( | ||
| tdelta = fields.datetime.now() - fields.Datetime.to_datetime( |
There was a problem hiding this comment.
to_datetime should no be necessary
| 1 AS "IsKit" | ||
| FROM product_capacity pc | ||
| ) | ||
| SELECT pm."ItemCode" as "reference", p."CodeBars" as "barcode", | ||
| sum(pm."Available") AS "qty_available" | ||
| /*,(CASE WHEN sum(pm."IsKit") > 0 THEN 'Y' ELSE 'N' END) AS "is_kit"*/ |
Comment on lines
136
to
130
| v1 = getattr(portal_product, k0, None) | ||
| v1 = portal_product[k0] |
There was a problem hiding this comment.
In the original line there was an implicit check, if k0 is not in portal_product then return None, you lost that in the new line, so it's not protected anymore
| stmnt = """WITH atp_onorder AS ( | ||
| SELECT lc."ItemCode", | ||
| lc."OpenCreQty" AS "OnOrder", | ||
| lc."ShipDate" |
KNVx
force-pushed
the
16.0-mig-lighting_porta_connector
branch
from
77a6f3a
to
f05930e
Compare
eantones
changed the title
eantones
force-pushed
the
16.0-mig-lighting_porta_connector
branch
2 times, most recently
from
d900b65
to
e587fd2
Compare
KNVx
added
to review
…e admin for manager
…ghting native ones
eantones
force-pushed
the
16.0-mig-lighting_porta_connector
branch
from
e587fd2
to
f4c1b06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.