Add tests #30
Add tests #30
Conversation
Note: setup.cfg ignores some flake8 which can be fixed after this merge
Remove .json from gitignore for tests Update README.md to show build status
Add refresh method to dcli.py for tests
Add test_auth + base
revert .gitignore for development setup
There was a problem hiding this comment.
Hi thanks for the PR but there are improvements that can be done.
Please go through tox and pytest. Tox will enable us to test linting as well as testing efficiently and pytest will allow us to focus on code coverage as well using pytest-codecov.
P.S. I am not one of the mentors. Feel free to bash me if you think my views are wrong 😛
| - pip install flake8 | ||
|
|
||
| install: | ||
| - python3 setup.py install |
There was a problem hiding this comment.
Hi, setup.py install command is kind of obsolete since pip came along.
| @@ -0,0 +1,9 @@ | |||
| requests | |||
There was a problem hiding this comment.
This file becomes redundant because the packages are mentioned in setup.py. If you are concerned about the development setup, populate this file only with -e .[dev], and mention dev dependencies if there are any in setup.py
There was a problem hiding this comment.
@inishchith Not familiar with the OAuth part tbh. Looks good to me otherwise :-)
|
@armudgal Thanks, really appreciate your time. I'll have a look at this in some time ;) |
|
@inishchith LGTM, apart from the requirements.txt part is it required as all the mentioned dependencies are already taken care of in setup.py |
I've added self-explanatory commit messages which will make this easier to reproduce.
@sauravchirania Can you please set this up locally.
I want you to form a basic structure for the other test and also review this PR and let me know if anything that can be done in a better way.
Footnotes