[Samantha Low] iP #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duke is unable to save task input and thus all tasks are lost once Duke terminates. Let's create a hard disk and enable duke to write to that database With tasks being save in hard disk whenever the task list changes, Duke can now save task inputs.
Duke reads all date and time as String object. Reading date and time as String limits the things Duke can do. Comparison of dates and times cannot be made as it is a String object. Let's change the String object to LocalDate and LocalTime object instead. In this way, Duke would be able to compare the Dates and organise tasks with respect to the dates on command.
# Conflicts: # src/main/java/Duke.java # src/main/java/Event.java # text-ui-test/EXPECTED.TXT
# Conflicts: # src/main/java/Deadline.java # src/main/java/Duke.java # src/main/java/Event.java # text-ui-test/EXPECTED.TXT
Duke class has too many functionalities/ purpose which violates the OOP principle. Let's add in more classes and make use of inheritance to group classes with similar functionalities together. Including more OOP allows the functionalities in Duke class to be passed to other classes. Adhere to OOP principle more adequately.
Duke class has too many functionalities/ purpose which violates the OOP principle. Let's add in more classes and make use of inheritance to group classes with similar functionalities together. Including more OOP allows the functionalities in Duke class to be passed to other classes. Adhere to OOP principle more adequately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.