[CS2103-T14-2] Advanced&Efficient #79
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxunn
pushed a commit
to yuxunn/tp
that referenced
this pull request
Oct 20, 2023
…s-and-leads Refactor addclient and addlead, Add test cases
Create view command
Modify Delete Command to use IC Number
Currently, the deletecommand is finding a patient to delete based on a filtered list rather than full list of patients It is important for a user to delete a patient outside of the filtered list as well. Create a getCurrentPatientList method in ModelManager.java to get the current list of patients
Make changes to edit and delete to access a patient in the list using ic number instead of patient index. Update User Guide to reflect these changes to edit and delete commands. Let's modify User Guide to ensure an easy tutorial for the users
Currently, the Add Command is implemented in a way that patients with similar ic numbers are allowed to be added Since ic numbers should be unique to every patient, it is important to inform users that the ic number of the new patient already exist Update AddCommand.java and AddCommandTest.java for ic number check
Update project from team repo
Currently the UI Component section of the developer guide is outdated and missing information related to the newly added RecordCard and RecordPanel classes. Updating the guide can help us keep better documentation of our project. Let's add the newly added RecordPanel and RecordCard classes to the UML diagram and alter the explanation to include them as well.
Implement JsonAdaptedRecord to enable JSON serialization for patient records. Update JsonSerializableAddressBook to work with new serialization. Enhance AddressBook model to support new serialization functionality. Introduce UniqueRecordList for ensuring record uniqueness.
- Test default constructor for Record. - Validate initialization with default values for fields. - Test setters and getters for initialObservations, diagnosis, treatmentPlan. - Ensure correct behavior of equals method.
- Detailed the JSON representation of the `Record` class. - Provided an example JSON format with explanations for each field. - Highlighted the default values used for certain fields when no data is provided.
Implement Record command to edit patient record. A Record attribute with relevant fields has been created for our Patient class. However, it cannot be edited and will stay as default values. Implementing a record function will allow us to take the first step in making a more viable product with suitable features. Let’s create the RecordCommand classes along with parser and test classes. Doing so will allow us to edit a patient’s record more efficiently.
Fix Checkstyle Errors Some classes have errors with checkstyle. Fixing the checkstyle errors will ensure that the errors do not accumulate. Let’s make sure we run checkstyle before pushing our code. Doing so will allow us to have cleaner code.
Modify User Guide to include Edit and Delete Features
Add Birthday class and save Assigned Department to Storage. Also modify delete and edit a patient to use IC Number instead of index of the patient.
Currently, the app does not support the editing of department or the assignment of a patient to a department. This functionality must be added for our app to be fully functional as per its functional requirements. Let's, * Add an AssignCommand class to handle the command execution * Add an AssignCommandParser class to parse user input * Add the command to the AddressBookParser
The current developer guide lacks details regarding our new features. Updating it now would alleviate the burden of having to do them later. Let's add a section about how our department attribute and assign department feature is implemented.
Modify DeveloperGuide.md to include enhancements
Update DG with Implementation of Record Command A New Record Command has been created and implemented. DG does not contain information about the Record Command. Updating the DG will ensure that DG is kept up to date and fellow developers understand the implementation of the newly added Record command. Let’s keep the DG up to date with our enhancements. Doing so allows everyone to be aware of the changes made and how they were made.
Update Add command to check for existing Ic Number
Currently there is placeholder text for the sequence diagram for assign department in the implementation section. Let's replace it with the actual diagram.
Update DG with Record Feature
Update DG with Assign Department Feature and Ui Component
Add `Record` JSON Storage Format to DG
Fix minor formatting issues in UG and DG
Update PPP and Format DG
Resize DG diagrams
Reize images again in DG
Update PPP
Considered potential design considerations under the Edit section of DeveloperGuide.md
Add design considerations under Edit feature
Currently the no of pull requests stated is incorrect There is a need to add correct information into PPP Update PPP regarding pull requests approved
* Update test cases for JsonAdaptedRecordTest and modify JsonAdaptedRecord.java. * Add JavaDocs to some files.
Update personal contribution to Project Portfolio Page (PPP).
Update single line in PPP
Update JsonAdaptedRecordTest
Fix UG & DG Bugs
Updated PPP with the relevant details on contributions through the project
Update PPP
Fix minor line spacing issues in PPP
Fix formatting issues in PPP
Fix minor formatting issues in PPP to ensure consistency.
Fix formatting issues in PPP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Advanced&Efficient helps Emergency Department (ED) doctors in logging patient reports and connect patients with relevant departments and doctors under time pressure during an emergency.